Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate sso resources from edp-install to gerrit-operator(#59) #60

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

alezander86
Copy link

Description
This commit introduces new functionality to support external secrets for the KubeRocketCI Gerrit Operator. It adds configurations and templates for managing secrets using AWS or generic providers via the External Secrets Operator. Key features include the ability to configure secret providers, specify secret store names, and manage Keycloak integration for SSO.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

The changes have been tested by deploying the updated Helm chart in a staging environment. The following tests were performed:

Verification of secret creation using both AWS Parameter Store and Secrets Manager.
Validation of Keycloak integration with the Gerrit SSO.
Ensured that existing deployments without external secrets continue to function without issues.
Steps to reproduce:

Deploy the updated Helm chart with externalSecrets.enabled set to true.
Configure the externalSecrets.type to either aws or generic.
Verify that the ExternalSecrets and SecretStores are created as expected.
Test the Keycloak SSO login flow.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@alezander86 alezander86 added the enhancement New feature or request label Sep 4, 2024
@alezander86 alezander86 self-assigned this Sep 4, 2024
@alezander86 alezander86 requested a review from a team as a code owner September 4, 2024 17:11
@alezander86 alezander86 force-pushed the EPMDEDP-14306 branch 3 times, most recently from 8aa8d2e to ccdbf5b Compare September 9, 2024 14:43
@alezander86
Copy link
Author

/recheck

@MykolaMarusenko MykolaMarusenko merged commit 60b146c into master Sep 19, 2024
2 checks passed
@MykolaMarusenko MykolaMarusenko deleted the EPMDEDP-14306 branch September 19, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants